add type annotations to io\formats\html.py #27355
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillAyd
approved these changes
Jul 12, 2019
| esc = OrderedDict([("&", r"&"), ("<", r"<"), (">", r">")]) | ||
| esc = OrderedDict( | ||
| [("&", r"&"), ("<", r"<"), (">", r">")] | ||
| ) # type: Union[OrderedDict[str, str], Dict] |
There was a problem hiding this comment.
I think also OK to just make this an ordereddict all of the time; simplifies annotation and code
There was a problem hiding this comment.
i was getting pandas\io\formats\html.py:145: error: Incompatible types in assignment (expression has type "Dict[<nothing>, <nothing>]", variable has type "OrderedDict[str, str]")
There was a problem hiding this comment.
Yea I so meant you could change the dict on line 145 to be an OrderedDict to match the signature here. I think OK to refactor code if it simplifies annotations and keeps same functionality, as there probably helps readability too
Though this is obviously fine as is too!
|
thanks @simonjayhawkins really nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.