CLN: simplify MultiIndex._shallow_copy #27187
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
topper-123
force-pushed
the
MultiIndex._shallow_copy
branch
from
6cadc23 to
e423c27
Compare
|
this looks ok. does this close any current issues? does this have any user facing effects? |
|
No, there's no issue for this, as this is small & internal. For an upcoming PR I need to call This has no user-facing effects. |
topper-123
force-pushed
the
MultiIndex._shallow_copy
branch
from
b82e7bf to
2e84323
Compare
k thanks |
|
thanks @topper-123 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MultiIndex._shallow_copydoesnt pass on kwargs, unlessvaluesis passed also, but just silently drops the kwargs. This makes_shallow_copycurrently a bit unreliable.This PR fixes that problem by calling
.copydirectly and passing kwargs tocopyand not passing the call through.view. Also,_shallow_copydoesn't call.viewon other index types, so this PR makesMultiIndex._shallow_copyconform with other index types.