Skip to content

DOC: Changed string to give correct output (#26865) #26886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

DOC: Changed string to give correct output (#26865) #26886

wants to merge 1 commit into from

Conversation

Kischy
Copy link
Contributor

@Kischy Kischy commented Jun 16, 2019

topper-123
topper-123 reviewed Jun 16, 2019
View reviewed changes
Copy link
Contributor

@topper-123 topper-123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Minor comment. Ping on green.

doc/source/user_guide/missing_data.rst
.. ipython:: python
df.replace([r'\.', r'(a)'], ['dot', '\1stuff'], regex=True)
df.replace([r'\.', r'(a)'], ['dot', 'stuff'], regex=True)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The correct string is a raw string r'\1stuff' to demonstrate replacement.

@topper-123 topper-123 added this to the 0.25.0 milestone Jun 16, 2019
@codecov
Copy link

codecov bot commented Jun 16, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@9326c1e). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #26886   +/-   ##
=========================================
  Coverage          ?   91.86%           
=========================================
  Files             ?      180           
  Lines             ?    50710           
  Branches          ?        0           
=========================================
  Hits              ?    46583           
  Misses            ?     4127           
  Partials          ?        0
Flag Coverage Δ
#multiple 90.45% <ø> (?)
#single 41.1% <ø> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9326c1e...ffd29d7. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jun 16, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@9326c1e). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #26886   +/-   ##
=========================================
  Coverage          ?   91.86%           
=========================================
  Files             ?      180           
  Lines             ?    50710           
  Branches          ?        0           
=========================================
  Hits              ?    46583           
  Misses            ?     4127           
  Partials          ?        0
Flag Coverage Δ
#multiple 90.45% <ø> (?)
#single 41.1% <ø> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9326c1e...ffd29d7. Read the comment docs.

@topper-123
Copy link
Contributor

Closing in favor of #26891.

@topper-123 topper-123 closed this Jun 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@topper-123 topper-123 topper-123 left review comments

Assignees
No one assigned
Labels
Docs
Projects
None yet
Milestone
0.25.0
Development

Successfully merging this pull request may close these issues.

possible error in documentation
2 participants
@Kischy @topper-123