-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
New benchmarks for parsing dates with dayfirst=True and format='%d-%m-%Y' #26360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New benchmarks for parsing dates with dayfirst=True and format='%d-%m-%Y' #26360
Conversation
great, can you show results for thee in the top-section. |
Codecov Report
@@ Coverage Diff @@
## master #26360 +/- ##
==========================================
- Coverage 91.81% 91.68% -0.14%
==========================================
Files 175 174 -1
Lines 52289 50700 -1589
==========================================
- Hits 48009 46482 -1527
+ Misses 4280 4218 -62
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #26360 +/- ##
==========================================
- Coverage 91.81% 91.68% -0.13%
==========================================
Files 175 174 -1
Lines 52289 50749 -1540
==========================================
- Hits 48009 46530 -1479
+ Misses 4280 4219 -61
Continue to review full report at Codecov.
|
yes making these consistent for benchmarks (and testing both cache on/off would be great) |
@jreback this is done. |
thanks @anmyachev |
git diff upstream/master -u -- "*.py" | flake8 --diff
Gap in performance between use dayfirst or format is acceptable now.
asv run -E existing -b ParseDateComparison -a warmup_time=2 -a sample_time=2
: