CLN: parse_date compat function #26038
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
reviewed
Apr 10, 2019
|
|
||
| # dateutil minimum version | ||
| import dateutil | ||
|
|
There was a problem hiding this comment.
we prob need to add a check on setup.py i think though
There was a problem hiding this comment.
dateutil is a required dependency though. Not sure why we would need a check.
There was a problem hiding this comment.
and this is where its guaranteed no? though I guess its the same as with numpy. you can install an older version but that would break in weird ways, so ok .
Codecov Report
@@ Coverage Diff @@
## master #26038 +/- ##
==========================================
- Coverage 91.89% 91.89% -0.01%
==========================================
Files 175 175
Lines 52478 52480 +2
==========================================
Hits 48227 48227
- Misses 4251 4253 +2
Continue to review full report at Codecov.
|
|
thanks! |
yhaque1213
pushed a commit
to yhaque1213/pandas
that referenced
this pull request
Apr 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master -u -- "*.py" | flake8 --diffMore
compat/__init__.pycleaning.Remove
parse_datein favor ofdateutil.parser.parsedirectly. pandas min dateutil version is 2.5.0 so the import check is unnecessary.