BUG: Fix user-facing AssertionError with to_html (#25608) #25620
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #25620 +/- ##
==========================================
+ Coverage 91.26% 91.26% +<.01%
==========================================
Files 173 173
Lines 52968 52969 +1
==========================================
+ Hits 48339 48340 +1
Misses 4629 4629
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #25620 +/- ##
==========================================
+ Coverage 91.26% 91.26% +<.01%
==========================================
Files 173 173
Lines 52968 52969 +1
==========================================
+ Hits 48339 48340 +1
Misses 4629 4629
Continue to review full report at Codecov.
|
gfyoung
reviewed
Mar 9, 2019
gfyoung
reviewed
Mar 9, 2019
gfyoung
added
Error Reporting
gfyoung
approved these changes
Mar 9, 2019
jreback
requested changes
Mar 10, 2019
doc/source/whatsnew/v0.25.0.rst
Outdated
| @@ -214,7 +214,7 @@ I/O | |||
| - Bug in :func:`read_json` for ``orient='table'`` when it tries to infer dtypes by default, which is not applicable as dtypes are already defined in the JSON schema (:issue:`21345`) | |||
| - Bug in :func:`read_json` for ``orient='table'`` and float index, as it infers index dtype by default, which is not applicable because index dtype is already defined in the JSON schema (:issue:`25433`) | |||
| - Bug in :func:`read_json` for ``orient='table'`` and string of float column names, as it makes a column name type conversion to Timestamp, which is not applicable because column names are already defined in the JSON schema (:issue:`25435`) | |||
| - | |||
| - Bug in converting to HTML when using an invalid type for ``classes`` parameter raised ``AsseertionError`` instead of ``TypeError`` (:issue:`25608`) | |||
There was a problem hiding this comment.
an you reference :meth:DataFrame.to_html; this is not a bug, rather a change.
jreback
approved these changes
Mar 10, 2019
|
thanks @ArtificialQualia |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master -u -- "*.py" | flake8 --diffI did not use an oxford comma in the error description, which is how it was written in the issue's expected result.