Skip to content

BUG: to_datetime(Timestamp, utc=True) localizes to UTC #24441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 26, 2018

Conversation

mroeschke
Copy link
Member

@mroeschke mroeschke added Bug Timezones Timezone data dtype labels Dec 26, 2018
@mroeschke mroeschke added this to the 0.24.0 milestone Dec 26, 2018
@codecov
Copy link

codecov bot commented Dec 26, 2018

Codecov Report

Merging #24441 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #24441      +/-   ##
==========================================
+ Coverage    92.3%    92.3%   +<.01%     
==========================================
  Files         163      163              
  Lines       51977    51979       +2     
==========================================
+ Hits        47979    47981       +2     
  Misses       3998     3998
Flag Coverage Δ
#multiple 90.71% <100%> (ø) ⬆️
#single 42.99% <50%> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/tools/datetimes.py 85.67% <100%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b4b38f...0718824. Read the comment docs.

@codecov
Copy link

codecov bot commented Dec 26, 2018

Codecov Report

Merging #24441 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #24441      +/-   ##
==========================================
+ Coverage    92.3%    92.3%   +<.01%     
==========================================
  Files         163      163              
  Lines       51977    51981       +4     
==========================================
+ Hits        47979    47983       +4     
  Misses       3998     3998
Flag Coverage Δ
#multiple 90.71% <100%> (ø) ⬆️
#single 42.99% <25%> (-0.01%) ⬇️
Impacted Files Coverage Δ
pandas/core/tools/datetimes.py 85.75% <100%> (+0.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b4b38f...d4a4a07. Read the comment docs.

Copy link
Member

@jschendel jschendel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm; one small comment on parametrizing

@jreback jreback merged commit 9fa063e into pandas-dev:master Dec 26, 2018
@jreback
Copy link
Contributor

jreback commented Dec 26, 2018

thanks @mroeschke

@mroeschke mroeschke deleted the to_datetime_timestamp_utc branch December 26, 2018 23:54
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Timezones Timezone data dtype
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: to_datetime(Timestamp) utc argument
3 participants