DEPS: bump xlrd min version to 1.0.0 #23774
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
added
Compat
|
removes all of those annoying warnings on 2.7 build :> |
Codecov Report
@@ Coverage Diff @@
## master #23774 +/- ##
=========================================
Coverage ? 92.28%
=========================================
Files ? 161
Lines ? 51451
Branches ? 0
=========================================
Hits ? 47483
Misses ? 3968
Partials ? 0
Continue to review full report at Codecov.
|
|
Hello @jreback! Thanks for updating the PR.
|
jreback
commented
Nov 19, 2018
| @@ -652,7 +653,8 @@ def get_value(self, series, key): | |||
| except TypeError: | |||
| pass | |||
|
|
|||
| key = Period(key, self.freq).ordinal | |||
| period = Period(key, self.freq) | |||
| key = period.value if isna(period) else period.ordinal | |||
There was a problem hiding this comment.
cc @jbrockmendel I had to make this change here. Not sure how this actually worked before.
remove numpy warnings on np.diff in boolean arrays
|
@TomAugspurger if any comments |
TomAugspurger
approved these changes
Nov 19, 2018
Pingviinituutti
pushed a commit
to Pingviinituutti/pandas
that referenced
this pull request
Feb 28, 2019
Pingviinituutti
pushed a commit
to Pingviinituutti/pandas
that referenced
this pull request
Feb 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove numpy warnings on np.diff in boolean arrays