DOC: Surface / doc mangle_dupe_cols in read_excel #23678
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gfyoung
added
Testing
|
Hello @gfyoung! Thanks for submitting the PR.
|
Codecov Report
@@ Coverage Diff @@
## master #23678 +/- ##
=======================================
Coverage 92.24% 92.24%
=======================================
Files 161 161
Lines 51318 51318
=======================================
Hits 47339 47339
Misses 3979 3979
Continue to review full report at Codecov.
|
|
thanks @gfyoung |
JustinZhengBC
pushed a commit
to JustinZhengBC/pandas
that referenced
this pull request
Nov 14, 2018
tm9k1
pushed a commit
to tm9k1/pandas
that referenced
this pull request
Nov 19, 2018
Pingviinituutti
pushed a commit
to Pingviinituutti/pandas
that referenced
this pull request
Feb 28, 2019
Pingviinituutti
pushed a commit
to Pingviinituutti/pandas
that referenced
this pull request
Feb 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref #10523 (comment).
We already support
mangle_dupe_cols(in the same vein as CSV). It was just hidden in**kwds. This just documents it inread_excel(it behaves exactly as it does inread_csv) and tests that we inform the end user thatmangle_dupe_cols=Falseis not supported...yet.Explicitly surfacing relevant CSV-related arguments will allow us to eventually remove the magical
**kwdsand obviate need for validation (xref #22189).