Skip to content

TST: Fix xfailing DataFrame arithmetic tests by transposing #23620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Nov 12, 2018
Merged

TST: Fix xfailing DataFrame arithmetic tests by transposing #23620

merged 6 commits into from
Nov 12, 2018

Conversation

jbrockmendel
Copy link
Member

@jbrockmendel jbrockmendel commented Nov 10, 2018 •
edited
Loading

  • closes #xxxx
  • tests added / passed
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

@pep8speaks
Copy link

pep8speaks commented Nov 10, 2018 •
edited
Loading

Hello @jbrockmendel! Thanks for updating the PR.

Comment last updated on November 11, 2018 at 20:09 Hours UTC

@codecov
Copy link

codecov bot commented Nov 11, 2018 •
edited
Loading

Codecov Report

Merging #23620 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #23620      +/-   ##
==========================================
+ Coverage   92.23%   92.23%   +<.01%     
==========================================
  Files         161      161              
  Lines       51288    51290       +2     
==========================================
+ Hits        47304    47306       +2     
  Misses       3984     3984
Flag Coverage Δ
#multiple 90.62% <100%> (ø) ⬆️
#single 42.26% <33.33%> (-0.01%) ⬇️
Impacted Files Coverage Δ
pandas/util/testing.py 86.08% <100%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58a59bd...2a1ceec. Read the comment docs.

@gfyoung gfyoung added Testing pandas testing functions or related to the test suite Numeric Operations Arithmetic, Comparison, and Logical operations labels Nov 11, 2018
gfyoung
gfyoung reviewed Nov 11, 2018
View reviewed changes
pandas/tests/arithmetic/test_datetime64.py
rng = tm.box_expected(rng, box_with_datetime)

# FIXME: calling with transpose=True raises ValueError
rng = tm.box_expected(rng, box, transpose=False)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we potentially have xfail tests for these?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea. I've implemented this for some of these (will push shortly). For others (particularly ones using box_with_period or box_with_datetimes instead of box) doing that becomes much hairier and I'm inclined to leave the FIXME notes for the time being.

gfyoung
gfyoung reviewed Nov 11, 2018
View reviewed changes
gfyoung
gfyoung reviewed Nov 11, 2018
View reviewed changes
jreback
jreback requested changes Nov 11, 2018
View reviewed changes
jreback
jreback reviewed Nov 11, 2018
View reviewed changes
@jreback jreback added this to the 0.24.0 milestone Nov 11, 2018
@jreback
Copy link
Contributor

jreback commented Nov 11, 2018

ok ping on green. (also if you have a chance to find the transpose on tz-DTI in a DataFrame issue) and link would be great.

@jbrockmendel
Copy link
Member Author

ping

@gfyoung gfyoung merged commit bb32564 into pandas-dev:master Nov 12, 2018
@jbrockmendel jbrockmendel deleted the noxfail3 branch November 12, 2018 00:24
JustinZhengBC pushed a commit to JustinZhengBC/pandas that referenced this pull request Nov 14, 2018
@jbrockmendel @JustinZhengBC
TST: Fix xfailing DataFrame arithmetic tests by transposing (pandas-d…
6401a4f 
…ev#23620)
tm9k1 pushed a commit to tm9k1/pandas that referenced this pull request Nov 19, 2018
@jbrockmendel @tm9k1
TST: Fix xfailing DataFrame arithmetic tests by transposing (pandas-d…
253dfaa 
…ev#23620)
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
@jbrockmendel @Pingviinituutti
TST: Fix xfailing DataFrame arithmetic tests by transposing (pandas-d…
8ccb1d7 
…ev#23620)
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
@jbrockmendel @Pingviinituutti
TST: Fix xfailing DataFrame arithmetic tests by transposing (pandas-d…
a1f06d4 
…ev#23620)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gfyoung gfyoung gfyoung left review comments

@jreback jreback jreback approved these changes

Assignees
No one assigned
Labels
Numeric Operations Arithmetic, Comparison, and Logical operations Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
0.24.0
Development

Successfully merging this pull request may close these issues.
4 participants
@jbrockmendel @pep8speaks @jreback @gfyoung