CLN: remove values attribute from datetimelike EAs

[jorisvandenbossche]

We don't need a .values attribute on the EAs (in the interface, we actually explicitly disallow it (in words and tests)).

I thought there was a reason during the PeriodArray PR that this couldn't yet be removed, but relevant tests seem to be passing locally.

cc @jbrockmendel

[pep8speaks]

Hello @jorisvandenbossche! Thanks for submitting the PR.

• There are no PEP8 issues in the file pandas/core/arrays/datetimelike.py !

• There are no PEP8 issues in the file pandas/core/arrays/datetimes.py !

• There are no PEP8 issues in the file pandas/core/arrays/timedeltas.py !

• There are no PEP8 issues in the file pandas/core/indexes/datetimes.py !

[jbrockmendel]

LGTM. Are there PeriodArray tests there were disabled that can now be un-disabled?

[jorisvandenbossche]

LGTM. Are there PeriodArray tests there were disabled that can now be un-disabled?

Yes, good catch.

[codecov]

Codecov Report

Merging #23603 into master will decrease coverage by <.01%.
The diff coverage is 80%.

@@            Coverage Diff             @@
##           master   #23603      +/-   ##
==========================================
- Coverage   92.25%   92.25%   -0.01%     
==========================================
  Files         161      161              
  Lines       51262    51260       -2     
==========================================
- Hits        47292    47290       -2     
  Misses       3970     3970

Flag	Coverage Δ
#multiple	90.63% <80%> (-0.01%)	⬇️
#single	42.33% <60%> (-0.01%)	⬇️

Impacted Files	Coverage Δ
pandas/core/arrays/timedeltas.py	93.78% <100%> (ø)	⬆️
pandas/core/indexes/datetimes.py	96.13% <100%> (ø)	⬆️
pandas/core/arrays/datetimes.py	98.42% <100%> (ø)	⬆️
pandas/core/arrays/datetimelike.py	95.9% <50%> (-0.03%)	⬇️
pandas/core/accessor.py	98.79% <0%> (ø)	⬆️
pandas/core/missing.py	91.7% <0%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f691711...b303239. Read the comment docs.