BUG: Fix error message for invalid HTML flavor #23550
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The flavors were not rendering properly in the string formatting. Closes pandas-devgh-23549. Follow-up to pandas-devgh-17660.
gfyoung
added
Bug
Error Reporting
|
Hello @gfyoung! Thanks for submitting the PR.
|
gfyoung
commented
Nov 7, 2018
| msg = r"\{" + flavor + r"\} is not a valid set of flavors" | ||
|
|
||
| with tm.assert_raises_regex(ValueError, msg): | ||
| read_html(url, "google", flavor=flavor) |
There was a problem hiding this comment.
We had a test for invalid flavors, but we were not checking the error message 😮
Should definitely discourage use of pytest.raises (with no match argument) unless there is a good reason for our not wanting to check the error message.
Codecov Report
@@ Coverage Diff @@
## master #23550 +/- ##
=======================================
Coverage 92.24% 92.24%
=======================================
Files 161 161
Lines 51224 51224
=======================================
Hits 47254 47254
Misses 3970 3970
Continue to review full report at Codecov.
|
TomAugspurger
approved these changes
Nov 8, 2018
|
Thanks. |
JustinZhengBC
pushed a commit
to JustinZhengBC/pandas
that referenced
this pull request
Nov 14, 2018
The flavors were not rendering properly in the string formatting. Closes pandas-devgh-23549. Follow-up to pandas-devgh-17660.
tm9k1
pushed a commit
to tm9k1/pandas
that referenced
this pull request
Nov 19, 2018
The flavors were not rendering properly in the string formatting. Closes pandas-devgh-23549. Follow-up to pandas-devgh-17660.
Pingviinituutti
pushed a commit
to Pingviinituutti/pandas
that referenced
this pull request
Feb 28, 2019
The flavors were not rendering properly in the string formatting. Closes pandas-devgh-23549. Follow-up to pandas-devgh-17660.
Pingviinituutti
pushed a commit
to Pingviinituutti/pandas
that referenced
this pull request
Feb 28, 2019
The flavors were not rendering properly in the string formatting. Closes pandas-devgh-23549. Follow-up to pandas-devgh-17660.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The flavors were not rendering properly in the string formatting.
Closes #23549.
Follow-up to #17660.