Skip to content

DEPR: favour sep over delimiter in pd.read_csv #23158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 8 commits into from
Closed

DEPR: favour sep over delimiter in pd.read_csv #23158

wants to merge 8 commits into from

Conversation

minggli
Copy link
Contributor

@minggli minggli commented Oct 14, 2018 •
edited
Loading

following discussion in #21996 and #7662, pandas uses sep extensively and in to_csv counterpart too. This PR deprecates delimiter argument from 0.24.0

comments welcome.

@pep8speaks
Copy link

Hello @minggli! Thanks for submitting the PR.

@minggli minggli changed the title DEPR: read_csv DEPR: favour sep over delimiter in pd.read_csv Oct 14, 2018
WillAyd
WillAyd requested changes Oct 15, 2018
View reviewed changes
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks generally good. Could use a whatsnew note. Also looks like some test cases need to still be updated per CI failures

@WillAyd WillAyd added IO CSV read_csv, to_csv Deprecate Functionality to remove in pandas labels Oct 15, 2018
@jorisvandenbossche
Copy link
Member

As mentioned in the issue, I think we should decide on deprecating this or not together with the discussion in #22639

@codecov
Copy link

codecov bot commented Oct 15, 2018

Codecov Report

Merging #23158 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #23158      +/-   ##
==========================================
+ Coverage   92.14%   92.14%   +<.01%     
==========================================
  Files         170      170              
  Lines       50992    50993       +1     
==========================================
+ Hits        46985    46986       +1     
  Misses       4007     4007
Flag Coverage Δ
#multiple 90.56% <100%> (ø) ⬆️
#single 42.32% <0%> (-0.01%) ⬇️
Impacted Files Coverage Δ
pandas/io/parsers.py 95.6% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9d237b...f2f1362. Read the comment docs.

@codecov
Copy link

codecov bot commented Oct 15, 2018 •
edited
Loading

Codecov Report

Merging #23158 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #23158      +/-   ##
==========================================
+ Coverage   92.22%   92.22%   +<.01%     
==========================================
  Files         169      169              
  Lines       50911    50912       +1     
==========================================
+ Hits        46954    46955       +1     
  Misses       3957     3957
Flag Coverage Δ
#multiple 90.65% <100%> (ø) ⬆️
#single 42.29% <0%> (-0.01%) ⬇️
Impacted Files Coverage Δ
pandas/io/parsers.py 95.6% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92fd46c...2d7b7ab. Read the comment docs.

@minggli minggli mentioned this pull request Oct 15, 2018
Open
@minggli minggli closed this Oct 16, 2018
@minggli minggli reopened this Oct 16, 2018
@minggli minggli closed this Oct 17, 2018
@minggli minggli reopened this Oct 17, 2018
@minggli
Copy link
Contributor Author

minggli commented Oct 17, 2018 •
edited
Loading

@WillAyd actioned. but something unrelated seems to break azure CI

jreback
jreback requested changes Oct 17, 2018
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think we are hold for now on this.

@minggli
Copy link
Contributor Author

minggli commented Oct 17, 2018

@jreback, cool, just ping if anything is decided or needs change! thanks 👍

@jreback
Copy link
Contributor

jreback commented Oct 17, 2018

will do @minggli

@minggli minggli force-pushed the depr/read_csv_delimiter branch from 712e77a to 2d7b7ab Compare October 24, 2018 12:38
@WillAyd
Copy link
Member

WillAyd commented Nov 24, 2018

Closing as stale. If we want another PR here should continue discussion back in original issue

@WillAyd WillAyd closed this Nov 24, 2018
@minggli minggli deleted the depr/read_csv_delimiter branch December 27, 2018 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillAyd WillAyd WillAyd requested changes

@jreback jreback jreback requested changes

Assignees
No one assigned
Labels
Deprecate Functionality to remove in pandas IO CSV read_csv, to_csv
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inconsistent behaviour on sep/delimiter for pandas.read_csv
5 participants
@minggli @pep8speaks @jorisvandenbossche @jreback @WillAyd