BUG: Fix wrong khash method definition #20966
Merged
+22
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #20966 +/- ##
=======================================
Coverage 91.81% 91.81%
=======================================
Files 153 153
Lines 49487 49487
=======================================
Hits 45437 45437
Misses 4050 4050
Continue to review full report at Codecov.
|
jreback
added
Bug
Indexing
jreback
requested changes
May 7, 2018
pandas/tests/indexing/test_loc.py
Outdated
| ] | ||
| ) | ||
|
|
||
| assert 1 == s.loc[np.iinfo('uint64').max - 1] |
There was a problem hiding this comment.
can you construct the expected frame and user assert_series_equal
| @@ -784,3 +784,16 @@ def convert_nested_indexer(indexer_type, keys): | |||
| index=pd.MultiIndex.from_product(keys)) | |||
|
|
|||
| tm.assert_series_equal(result, expected) | |||
|
|
|||
| def test_loc_uint64(self): | |||
| # GH20722 | |||
There was a problem hiding this comment.
can you add a 1 line comment about what this is about
Licht-T
force-pushed
the
fix-wrong-khash-method-definition
branch
from
519bf33 to
69a01a3
Compare
|
Thanks @jreback, fixed! |
jreback
approved these changes
May 8, 2018
|
lgtm. ping on green. I pushed some cleaning of the test. |
|
thanks @Licht-T |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master -u -- "*.py" | flake8 --diff