-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
BUG: Fix wrong khash method definition #20966
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: Fix wrong khash method definition #20966
Conversation
Codecov Report
@@ Coverage Diff @@
## master #20966 +/- ##
=======================================
Coverage 91.81% 91.81%
=======================================
Files 153 153
Lines 49487 49487
=======================================
Hits 45437 45437
Misses 4050 4050
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you add a whatsnew in bugs / indexing
pandas/tests/indexing/test_loc.py
Outdated
] | ||
) | ||
|
||
assert 1 == s.loc[np.iinfo('uint64').max - 1] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you construct the expected frame and user assert_series_equal
@@ -784,3 +784,16 @@ def convert_nested_indexer(indexer_type, keys): | |||
index=pd.MultiIndex.from_product(keys)) | |||
|
|||
tm.assert_series_equal(result, expected) | |||
|
|||
def test_loc_uint64(self): | |||
# GH20722 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you add a 1 line comment about what this is about
519bf33
to
69a01a3
Compare
Thanks @jreback, fixed! |
lgtm. ping on green. I pushed some cleaning of the test. |
thanks @Licht-T |
git diff upstream/master -u -- "*.py" | flake8 --diff