Skip to content

BUG: Fix wrong khash method definition #20966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Licht-T
Copy link
Contributor

@Licht-T Licht-T commented May 6, 2018

@codecov
Copy link

codecov bot commented May 6, 2018

Codecov Report

Merging #20966 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #20966   +/-   ##
=======================================
  Coverage   91.81%   91.81%           
=======================================
  Files         153      153           
  Lines       49487    49487           
=======================================
  Hits        45437    45437           
  Misses       4050     4050
Flag Coverage Δ
#multiple 90.21% <ø> (ø) ⬆️
#single 41.85% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc50bde...375c656. Read the comment docs.

@jreback jreback added Bug Indexing Related to indexing on series/frames, not to indexes themselves labels May 7, 2018
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a whatsnew in bugs / indexing

]
)

assert 1 == s.loc[np.iinfo('uint64').max - 1]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you construct the expected frame and user assert_series_equal

@@ -784,3 +784,16 @@ def convert_nested_indexer(indexer_type, keys):
index=pd.MultiIndex.from_product(keys))

tm.assert_series_equal(result, expected)

def test_loc_uint64(self):
# GH20722
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a 1 line comment about what this is about

@Licht-T Licht-T force-pushed the fix-wrong-khash-method-definition branch from 519bf33 to 69a01a3 Compare May 7, 2018 13:59
@Licht-T
Copy link
Contributor Author

Licht-T commented May 7, 2018

Thanks @jreback, fixed!

@jreback jreback added this to the 0.23.0 milestone May 8, 2018
@jreback
Copy link
Contributor

jreback commented May 8, 2018

lgtm. ping on green. I pushed some cleaning of the test.

@jreback jreback merged commit d98f25a into pandas-dev:master May 8, 2018
@jreback
Copy link
Contributor

jreback commented May 8, 2018

thanks @Licht-T

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Indexing Related to indexing on series/frames, not to indexes themselves
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Overflow encountered when using .loc with UInt64Index
2 participants