centralize and split frame division tests #19527
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #19527 +/- ##
==========================================
- Coverage 91.62% 86.09% -5.53%
==========================================
Files 150 150
Lines 48680 48681 +1
==========================================
- Hits 44603 41914 -2689
- Misses 4077 6767 +2690
Continue to review full report at Codecov.
|
gfyoung
added
Testing
gfyoung
reviewed
Feb 3, 2018
| second = pd.Series([np.nan, np.nan, np.nan, 0]) | ||
| expected = pd.DataFrame({'first': first, 'second': second}) | ||
|
|
||
| # numpy has a slightly different (wrong) treatement |
There was a problem hiding this comment.
treatement --> treatment (fix this everywhere)
gfyoung
reviewed
Feb 3, 2018
| # GH#3590, modulo as ints | ||
| df = pd.DataFrame({'first': [3, 4, 5, 8], 'second': [0, 0, 0, 3]}) | ||
|
|
||
| # this is technically wrong as the integer portion is coerced to float |
There was a problem hiding this comment.
Add a comma between "wrong" and "as"
|
thanks! |
harisbal
pushed a commit
to harisbal/pandas
that referenced
this pull request
Feb 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master -u -- "*.py" | flake8 --diff