DOC: correct merge_ordered example #19401
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… merge_ordered. adding a test corresponding to this example.
|
Hello @raph-m! Thanks for updating the PR. Cheers ! There are no PEP8 issues in this Pull Request. 🍻 Comment last updated on January 25, 2018 at 22:50 Hours UTC |
|
Hi, |
|
Hello, the appveyor test did not pass but the errors do not appear to be related to my modifications. Please let me know if I should make changes to pass the AppVeyor test. |
jorisvandenbossche
changed the title
|
@raph-m Don't worry about the appveyor tests, that is indeed unrelated (and being fixed) Looks good for the rest! |
jorisvandenbossche
approved these changes
Jan 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update of incorrect documentation example for merge_ordered.
adding a test corresponding to this example.
closes DOC: incorrect example result for pd.merge_ordered #19393
tests added / passed
passes
git diff upstream/master -u -- "*.py" | flake8 --diffwhatsnew entry