Remove unused Index attributes #19397
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #19397 +/- ##
==========================================
- Coverage 91.62% 91.62% -0.01%
==========================================
Files 150 150
Lines 48729 48716 -13
==========================================
- Hits 44649 44636 -13
Misses 4080 4080
Continue to review full report at Codecov.
|
jreback
requested changes
Jan 26, 2018
| @@ -141,12 +141,10 @@ class Index(IndexOpsMixin, PandasObject): | |||
| _join_precedence = 1 | |||
|
|
|||
| # Cython methods | |||
| _arrmap = libalgos.arrmap_object | |||
There was a problem hiding this comment.
so I think you can also remove some of the cython code which implements (not float/object though)
There was a problem hiding this comment.
arrmap_object is used in core.ops
There was a problem hiding this comment.
right, but can remve the rest of the code. pls add to the list.
There was a problem hiding this comment.
right, but can remve the rest of the code. pls add to the list.
The rest of what code?
jreback
approved these changes
Jan 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.