small cleanups aggregated #19328
Merged
small cleanups aggregated #19328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #19328 +/- ##
==========================================
- Coverage 91.53% 91.52% -0.01%
==========================================
Files 150 150
Lines 48739 48725 -14
==========================================
- Hits 44612 44595 -17
- Misses 4127 4130 +3
Continue to review full report at Codecov.
|
jreback
approved these changes
Jan 21, 2018
| @@ -4275,8 +4272,7 @@ def _ensure_index(index_like, copy=False): | |||
| def _get_na_value(dtype): | |||
| if is_datetime64_any_dtype(dtype) or is_timedelta64_dtype(dtype): | |||
| return libts.NaT | |||
| return {np.datetime64: libts.NaT, | |||
There was a problem hiding this comment.
if you would make a note, we already have routines for this entire bizness of _get_na_value
pandas.core.dtypes.missing.infer_dtype_for_scalar, so these should be replaced
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few cleanups that I've found myself making repeatedly in WIP branches, figured it was worth pushing them to avoid cluttering diffs down the road.
git diff upstream/master -u -- "*.py" | flake8 --diff