Skip to content

Separate test_numeric_compat into method-specific tests #19321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 21, 2018

Conversation

jbrockmendel
Copy link
Member

A more reasonably-scoped attempt at #19255.

  • closes #xxxx
  • tests added / passed
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

@codecov
Copy link

codecov bot commented Jan 20, 2018

Codecov Report

Merging #19321 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #19321   +/-   ##
=======================================
  Coverage   91.53%   91.53%           
=======================================
  Files         150      150           
  Lines       48739    48739           
=======================================
  Hits        44612    44612           
  Misses       4127     4127
Flag Coverage Δ
#multiple 89.9% <ø> (ø) ⬆️
#single 41.73% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1245f06...3df8a1f. Read the comment docs.

@jreback jreback added Testing pandas testing functions or related to the test suite Numeric Operations Arithmetic, Comparison, and Logical operations labels Jan 21, 2018
@jreback jreback added this to the 0.23.0 milestone Jan 21, 2018
@jreback jreback merged commit 04f6f8b into pandas-dev:master Jan 21, 2018
@jreback
Copy link
Contributor

jreback commented Jan 21, 2018

thanks, nice scope, means merge faster :>

@jbrockmendel jbrockmendel deleted the numeric_tests branch January 21, 2018 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Numeric Operations Arithmetic, Comparison, and Logical operations Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants