-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
DOC: Add clear and other parameter docs to assert_produces_warning #19066
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
pandas/util/testing.py
Outdated
|
||
Parameters | ||
---------- | ||
expected_warning : class Warning|False|None, default Warning |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{Warning, False, None}
pandas/util/testing.py
Outdated
suppressed by this context manager. If ``None`` is specified, | ||
the ``__warningsregistry__`` keeps track of which warnings have been | ||
shown, and does not show them again. | ||
check_stacklevel : bool, default true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
true -> True
pandas/util/testing.py
Outdated
line that implements the function is displayed. | ||
|
||
Examples | ||
---------- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make this same length as Examples
pandas/util/testing.py
Outdated
Specifies whether warnings are ignored, displayed, or turned | ||
into errors. | ||
Valid values are: | ||
"error" - turns matching warnings into exeptions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you use * for the bullets.
Codecov Report
@@ Coverage Diff @@
## master #19066 +/- ##
=======================================
Coverage 91.51% 91.51%
=======================================
Files 148 148
Lines 48780 48780
=======================================
Hits 44639 44639
Misses 4141 4141
Continue to review full report at Codecov.
|
Thanks for the quick and thorough review @jreback. I've pushed your requested changes. |
can you |
I did |
|
Whoops, looks like some unrelated commits got in here. Do you want help walking through the git commands? I think the simplest version would be
That'll rewrite history (which is usually not good, but OK for this PR) and hopefully clean everything up. |
ff077c3
to
f46920c
Compare
@TomAugspurger Hi Tom. I ran the commands above. Are there any additional commands I need to run to deliver this change? Thanks! |
The diff looks good now, thanks. Let us know if you see that the tests all pass before we do. |
I need help with troubleshooting the travis-ci errors. I don't understand what the problem is. Thanks! |
I restarted those. I think boto (one of our dependencies) had a bad release yesterday. They've been passing today. Ping on green :) |
thanks! |
clear
parameter