selected numeric data before correlation #18651
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
requested changes
Dec 6, 2017
pandas/tests/frame/test_analytics.py
Outdated
| @@ -240,6 +240,15 @@ def test_corrwith_matches_corrcoef(self): | |||
| tm.assert_almost_equal(c1, c2) | |||
| assert c1 < 1 | |||
|
|
|||
| def test_corrwith_mixed_dtypes(self): | |||
| df = pd.DataFrame({'a': [1, 4, 3, 2], 'b': [4, 6, 7, 3], | |||
There was a problem hiding this comment.
add the issue number as a comment
jreback
added
Dtype Conversions
|
actually do this for 0.22 |
Codecov Report
@@ Coverage Diff @@
## master #18651 +/- ##
==========================================
- Coverage 91.6% 91.57% -0.03%
==========================================
Files 153 153
Lines 51250 51221 -29
==========================================
- Hits 46947 46908 -39
- Misses 4303 4313 +10
Continue to review full report at Codecov.
|
jreback
approved these changes
Dec 6, 2017
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master -u -- "*.py" | flake8 --diffI select the numeric data before the calculation happens with a Series.
No whatsnew entry yet.