Skip to content

cleaned up imports #18264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 23, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions pandas/core/api.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,9 @@
from pandas.core.frame import DataFrame
from pandas.core.panel import Panel, WidePanel
from pandas.core.panel4d import Panel4D
from pandas.core.reshape.reshape import (
pivot_simple as pivot, get_dummies)
from pandas.core.reshape.melt import lreshape, wide_to_long

# TODO: Remove import when statsmodels updates #18264
from pandas.core.reshape.reshape import get_dummies

from pandas.core.indexing import IndexSlice
from pandas.core.tools.numeric import to_numeric
Expand Down
3 changes: 2 additions & 1 deletion pandas/core/reshape/api.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
# flake8: noqa

from pandas.core.reshape.concat import concat
from pandas.core.reshape.melt import melt
from pandas.core.reshape.melt import melt, lreshape, wide_to_long
from pandas.core.reshape.reshape import pivot_simple as pivot, get_dummies
from pandas.core.reshape.merge import (
merge, ordered_merge, merge_ordered, merge_asof)
from pandas.core.reshape.pivot import pivot_table, crosstab
Expand Down
14 changes: 8 additions & 6 deletions pandas/core/reshape/melt.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,14 +6,12 @@
from pandas import compat
from pandas.core.categorical import Categorical

from pandas.core.frame import DataFrame
from pandas.core.index import MultiIndex
from pandas.core.dtypes.generic import ABCMultiIndex

from pandas.core.frame import _shared_docs
from pandas.util._decorators import Appender

import re
import pandas.core.dtypes.concat as _concat
from pandas.core.dtypes.missing import notna


Expand All @@ -27,7 +25,7 @@ def melt(frame, id_vars=None, value_vars=None, var_name=None,
if id_vars is not None:
if not is_list_like(id_vars):
id_vars = [id_vars]
elif (isinstance(frame.columns, MultiIndex) and
elif (isinstance(frame.columns, ABCMultiIndex) and
not isinstance(id_vars, list)):
raise ValueError('id_vars must be a list of tuples when columns'
' are a MultiIndex')
Expand All @@ -39,7 +37,7 @@ def melt(frame, id_vars=None, value_vars=None, var_name=None,
if value_vars is not None:
if not is_list_like(value_vars):
value_vars = [value_vars]
elif (isinstance(frame.columns, MultiIndex) and
elif (isinstance(frame.columns, ABCMultiIndex) and
not isinstance(value_vars, list)):
raise ValueError('value_vars must be a list of tuples when'
' columns are a MultiIndex')
Expand All @@ -54,7 +52,7 @@ def melt(frame, id_vars=None, value_vars=None, var_name=None,
frame.columns = frame.columns.get_level_values(col_level)

if var_name is None:
if isinstance(frame.columns, MultiIndex):
if isinstance(frame.columns, ABCMultiIndex):
if len(frame.columns.names) == len(set(frame.columns.names)):
var_name = frame.columns.names
else:
Expand All @@ -81,6 +79,7 @@ def melt(frame, id_vars=None, value_vars=None, var_name=None,
mdata[col] = np.asanyarray(frame.columns
._get_level_values(i)).repeat(N)

from pandas import DataFrame
return DataFrame(mdata, columns=mcolumns)


Expand Down Expand Up @@ -137,6 +136,8 @@ def lreshape(data, groups, dropna=True, label=None):

for target, names in zip(keys, values):
to_concat = [data[col].values for col in names]

import pandas.core.dtypes.concat as _concat
mdata[target] = _concat._concat_compat(to_concat)
pivot_cols.append(target)

Expand All @@ -150,6 +151,7 @@ def lreshape(data, groups, dropna=True, label=None):
if not mask.all():
mdata = dict((k, v[mask]) for k, v in compat.iteritems(mdata))

from pandas import DataFrame
return DataFrame(mdata, columns=id_cols + pivot_cols)


Expand Down
3 changes: 1 addition & 2 deletions pandas/tests/reshape/test_reshape.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,7 @@

from pandas.util.testing import assert_frame_equal

from pandas.core.reshape.reshape import get_dummies
from pandas.core.reshape.melt import melt, lreshape, wide_to_long
from pandas import melt, lreshape, wide_to_long, get_dummies
import pandas.util.testing as tm
from pandas.compat import range, u

Expand Down