follow-up to #17943, closes #5168 #18033
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gfyoung
added
Bug
Docs
Error Reporting
gfyoung
approved these changes
Oct 30, 2017
Codecov Report
@@ Coverage Diff @@
## master #18033 +/- ##
==========================================
+ Coverage 91.24% 91.25% +<.01%
==========================================
Files 163 163
Lines 50100 50100
==========================================
+ Hits 45714 45717 +3
+ Misses 4386 4383 -3
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #18033 +/- ##
==========================================
+ Coverage 91.24% 91.25% +<.01%
==========================================
Files 163 163
Lines 50100 50100
==========================================
+ Hits 45714 45717 +3
+ Misses 4386 4383 -3
Continue to review full report at Codecov.
|
|
can you amend the issue in the whatsnew to include #5168 as well (the issue that fixed this). |
|
lgtm otherwise. |
|
thanks! |
peterpanmj
pushed a commit
to peterpanmj/pandas
that referenced
this pull request
Oct 31, 2017
No-Stream
pushed a commit
to No-Stream/pandas
that referenced
this pull request
Nov 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master -u -- "*.py" | flake8 --diff