BUG: duplicate indexing with embedded non-orderables (#17610) #17851
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #17851 +/- ##
==========================================
- Coverage 91.25% 91.21% -0.05%
==========================================
Files 163 163
Lines 50038 50039 +1
==========================================
- Hits 45661 45641 -20
- Misses 4377 4398 +21
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #17851 +/- ##
==========================================
- Coverage 91.23% 91.22% -0.02%
==========================================
Files 163 163
Lines 50112 50112
==========================================
- Hits 45722 45713 -9
- Misses 4390 4399 +9
Continue to review full report at Codecov.
|
gfyoung
added
Bug
Indexing
jschendel
reviewed
Oct 12, 2017
pandas/tests/series/test_indexing.py
Outdated
| @@ -546,6 +546,21 @@ def test_getitem_setitem_periodindex(self): | |||
| result[4:8] = ts[4:8] | |||
| assert_series_equal(result, ts) | |||
|
|
|||
| def test_getitem_with_duplicates_indices(self): | |||
| s = pd.Series({1: 12, 2: [1, 2, 2, 3]}) | |||
There was a problem hiding this comment.
Can you add the github issue number as a comment here?
jreback
requested changes
Oct 13, 2017
pandas/core/series.py
Outdated
| @@ -626,9 +626,10 @@ def __getitem__(self, key): | |||
| # we need to box if we have a non-unique index here | |||
| # otherwise have inline ndarray/lists | |||
| if not self.index.is_unique: | |||
| result = self._constructor( | |||
| result, index=[key] * len(result), | |||
There was a problem hiding this comment.
you need to do something like
index = self.index[self.index.get_loc(key)]
jreback
requested changes
Oct 28, 2017
| @@ -978,6 +978,7 @@ Indexing | |||
| - Bug in :meth:`DataFrame.first_valid_index` and :meth:`DataFrame.last_valid_index` when no valid entry (:issue:`17400`) | |||
| - Bug in :func:`Series.rename` when called with a callable, incorrectly alters the name of the ``Series``, rather than the name of the ``Index``. (:issue:`17407`) | |||
| - Bug in :func:`String.str_get` raises ``IndexError`` instead of inserting NaNs when using a negative index. (:issue:`17704`) | |||
|
can you rebase / update |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BUG: duplicate indexing with embedded non-orderables (#17610)
git diff upstream/master -u -- "*.py" | flake8 --diff