TST: fix excel tests when openpyxl is not installed #15209
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorisvandenbossche
added
IO Excel
|
+1 I thought I had fixed these........ |
|
Is it worth to have a build without openpyxl for this? |
|
Although it should be a build without openpyxl, but with xlrd/xlwt, to have this surface, and it's also not a bug, only a testing thing, so probably not worth it |
|
prob not worth it, but no objection if u want to change one (say 3.4_nslow) |
Current coverage is 85.98% (diff: 100%)@@ master #15209 diff @@
==========================================
Files 140 140
Lines 51273 51272 -1
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 44091 44085 -6
- Misses 7182 7187 +5
Partials 0 0
|
|
thanks! |
AnkurDedania
pushed a commit
to AnkurDedania/pandas
that referenced
this pull request
Mar 21, 2017
Some tests fail when you don't have openpyxl installed, so explicitly skipping those (they need it for certain exts because they write a frame in the test) Author: Joris Van den Bossche <[email protected]> Closes pandas-dev#15209 from jorisvandenbossche/openpyxl-noimport and squashes the following commits: f1cbe8f [Joris Van den Bossche] TST: fix excel tests when openpyxl is not installed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some tests fail when you don't have openpyxl installed, so explicitly skipping those (they need it for certain exts because they write a frame in the test)