BUG: Error upon Series.Groupby.nunique with empty Series (#12553) #14770
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think nunique was one of a few cases I hadn't completed when trying to solve some of these groupby + empty series. Generally I had tried to remove empty as a special case. But if that's not possible, sobeit.
|
jreback
reviewed
Nov 30, 2016
| @@ -2898,6 +2898,10 @@ def true_and_notnull(x, *args, **kwargs): | |||
| def nunique(self, dropna=True): | |||
| """ Returns number of unique elements in the group """ | |||
| ids, _, _ = self.grouper.group_info | |||
|
|
|||
| if len(ids) == 0: | |||
| return Series(index=self.dtype.index, name=self.name) | |||
jreback
reviewed
Nov 30, 2016
|
|
||
| if len(ids) == 0: | ||
| return Series(index=self.dtype.index, name=self.name) | ||
|
|
||
| val = self.obj.get_values() | ||
|
|
There was a problem hiding this comment.
actualy I'd rather you fix like this:
diff --git a/pandas/core/groupby.py b/pandas/core/groupby.py
index afddb86..f720a62 100644
--- a/pandas/core/groupby.py
+++ b/pandas/core/groupby.py
@@ -2928,7 +2928,10 @@ class SeriesGroupBy(GroupBy):
inc[idx] = 1
out = np.add.reduceat(inc, idx).astype('int64', copy=False)
- res = out if ids[0] != -1 else out[1:]
+ if len(ids):
+ res = out if ids[0] != -1 else out[1:]
+ else:
+ res = out[1:]
ri = self.grouper.result_index
# we might have duplications among the bins
…12553) Modified tests simplify tests Add whatsnew Moved len check
|
Thanks @jreback, moved the |
|
thanks @mroeschke |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master | flake8 --diffSimilar to #12560, but it has appeared to stall. Wanted to push it along.