WIP/API: add magic 'X' for selection #14209
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master | flake8 --diff
This is very WIP, but wanted to put it up and show the general direction. This adds essentially a modified version of
pandas_ply
that produces plain callables that can be passed to the existing[]
/assign
methods. Short demo below.One thing that's tricky is figuring out when an expression is "complete."
pandas_ply
anddplython
don't have to do this because they use a special method to instantiate the selection, but I'd prefer not to do this if possible, so this doesn't touch any pandas internals. There's one example below (X.c.str.upper()
) that shows where the current heuristic is failing.cc @shoyer, @jreback, @joshuahhh @dodger487, welcome any thoughts