BUG: preserve join keys dtype #13170
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
added
Bug
Indexing
pandas/tseries/period.py
Outdated
Contributor
Author
There was a problem hiding this comment.
@sinhrks I wish that could get some more uniformity w.r.t. Periods. I realize that there is a bug here with other which I fixed in tseries/base.py/.where, end up duplicating code here.
Member
There was a problem hiding this comment.
Contributor
Author
There was a problem hiding this comment.
its more complicated. I needed prelim logic different fro dti & period, so would have to have a helper function. We do this a fair amount, e.g. process for timezones, run a function, then reverse. Its ok the way we do it now, but it does duplicate some code.
jreback
force-pushed
the
merge2
branch
5 times, most recently
from
79f3b9d to
3c535fa
Compare
jreback
force-pushed
the
merge2
branch
4 times, most recently
from
05d045a to
10d52f6
Compare
Contributor
Author
|
ok, removed the dep on my other PR. @sinhrks @jorisvandenbossche @TomAugspurger comments? |
jreback
force-pushed
the
merge2
branch
2 times, most recently
from
d864f2c to
971ed21
Compare
Contributor
Author
|
@sinhrks any comments on this? |
closes pandas-dev#8596 xref to pandas-dev#13169 as assignment of Index of bools not retaining dtype
jreback
added a commit
that referenced
this pull request
May 27, 2016
This was referenced Jun 6, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Index.wheremethod for all Index types (likenp.where/Series.where), but preserves dtypes