Fixed #12651: providing links to the .cum* in .expanding #12673
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pandas-dev#12651 commit for the .cum* in .expanding
3 tasks
|
sectional links provided. |
prabhjotsumman
changed the title
| @@ -578,6 +578,7 @@ they are implemented in pandas such that the following two calls are equivalent: | |||
| df.expanding(min_periods=1).mean()[:5] | |||
|
|
|||
| These have a similar set of methods to ``.rolling`` methods. | |||
| Please see the :ref:`cumsum, cummax, cummin, cumprod <basics.stats>` | |||
There was a problem hiding this comment.
I wold expect a note:: section here explaining the differnce as I have noted in the issue
|
pls reopen if you like to update according to comments |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes DOC: improve cross-links in docs between .expanding and .cum* #12651
tests added / passed
passes
git diff upstream/master | flake8 --diffwhatsnew entry
DOC: improve cross-links in docs between .expanding and .cum* #12651
commit for the .cum* in .expanding