BUG: implement .sort_index(...inplace=True) for #11402 #11422
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -5328,6 +5328,26 @@ def test_sort_index(self): | |||
| assert_series_equal(sorted_series, | |||
| self.ts.reindex(self.ts.index[::-1])) | |||
|
|
|||
| def test_sort_index_inplace(self): | |||
| rindex = list(self.ts.index) | |||
There was a problem hiding this comment.
add the issue number as a comment
|
pls also add a whatsnew note for 0.17.1 (put in API changes even though this is a bug-fix, as it technically is an api change) |
jreback
added
Bug
Compat
jreback
changed the title
cfperez
force-pushed
the
cfperez-sortindex
branch
from
721c81e to
11f11a0
Compare
|
Updated and running green. |
|
merged via 1135ce3 thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #11402
Adds inplace sort_index() for Series.