DOC: update ipython sphinxext for IPython 4.0 #10868
Conversation
| from IPython import Config, InteractiveShell | ||
| try: | ||
| from traitlets.config import Config | ||
| except ImportError: |
There was a problem hiding this comment.
the fact that you have to change this is very odd. is this in their release notes? (or are we just using reallly old syntax)
There was a problem hiding this comment.
They split traitlets into a new repo.
There was a problem hiding this comment.
I don't know. Possibly they forgot to put a shim for Config (but this code is normally included in ipython itself, so then it doesn't matter. But is seems that Config is rather public object)
There was a problem hiding this comment.
yeh that seems rather extreme to not to shim. I know we get blamed for any teeny tiny little change :)
There was a problem hiding this comment.
They put a warning on the module (https://github.com/ipython/ipython/blob/master/IPython/config.py), but not on the object in the top-level namespace apparantly.
@takluyver is this an oversight of IPython or on purpose?
There was a problem hiding this comment.
Config is gone entirely from the top-level namespace on IPython 4.0
EDIT: which it the point of the PR (duh). Anyway +1 on the change.
There was a problem hiding this comment.
Apologies for the delayed response. I think it's an oversight that we forgot to shim for the top level module, but now that it's out there without the shim, we're probably not going to go back and add new shims, so this fix should be correct anyway.
…xt-update DOC: update ipython sphinxext for IPython 4.0
No description provided.