Skip to content

Conversation

IamGianluca
Copy link

closes #10750

Add ability to 'read_sql_table' to read views and implement an unit test to check its behaviour

@jorisvandenbossche jorisvandenbossche added IO SQL to_sql, read_sql, read_sql_query Enhancement labels Aug 11, 2015
@jorisvandenbossche jorisvandenbossche added this to the 0.17.0 milestone Aug 11, 2015
@jorisvandenbossche
Copy link
Member

Looks good!

  • Can you add a small note in the whatsnew file (in the 'other enhancements' section)
  • You included the test in _TestSQLApi which only tests the API with sqlite. I think this is OK (I don't see potential differences between database flavours), but in that case the sql code for the different flavors is not needed.

Gianluca Rossi and others added 15 commits August 11, 2015 20:12
…en only few of them exist, and new column names are not provided via the 'keys' argument. Closes #10698
- Added hint regarding pip install on low memory machines.
- Added hint to python 3 version of pandas from distributon repos.
…0_fix

Conflicts:
	pandas/io/tests/test_sql.py
# The first commit's message is:
Merge

# This is the 2nd commit message:

BUG: Categorical doesn't show tzinfo properly

# This is the 3rd commit message:

ENH: duplicated and drop_duplicates now accept take=all kw

# This is the 4th commit message:

TST: make assertion messages more understandable

# This is the 5th commit message:

Update install.rst

- Added hint regarding pip install on low memory machines.
- Added hint to python 3 version of pandas from distributon repos.
@jorisvandenbossche
Copy link
Member

@IamGianluca for future reference, it is not needed to open a new PR if something went wrong. You can always rebase the current branch and force push again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement IO SQL to_sql, read_sql, read_sql_query
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: read_sql_table can't find views
3 participants