DOC: Note on PyTables index issue and additional Contributing refinements #10069
Conversation
| .. warning:: | ||
|
|
||
| There is a ``PyTables`` indexing bug which may appear when querying stores using an index. If you see a subset of results being returned, upgrade to ``PyTables`` >= 3.2. Stores created previously will need to be rewritten using the updated version. | ||
|
|
There was a problem hiding this comment.
This is only true for when using compression, IIRC.
There was a problem hiding this comment.
the "stores need to be rewritten" part? I rewrote the test table uncompressed in the old version and querying in the new version does not return all rows. I think it needs to be done regardless.
There was a problem hiding this comment.
oh, ok. I just wanted to make it as specific as possible. This sounds like its ALWAYS a bug. IIRC I think you actually have to specify start or stop when you query. (e.g. your query needs to be something like: s.select('df',where='.....',start=10), right? (iow it has to be a chunked query)
There was a problem hiding this comment.
It doesn't need to be chunked. My sample was just s.select('df', where=Term(...)). I tried to make it non-specific by "may appear."
There was a problem hiding this comment.
Since this is such a nuanced bug, I think it would be worth making 3.2 a requirement once that is officially out.
There was a problem hiding this comment.
sure, let's make an issue for 0.17.0 for that, maybe now just update install.rst to say highly recommened to use 3.2
|
@rockg looks good @jorisvandenbossche pls have a look |
| Finally, commit your changes to your local repository with an explanatory message. An informal | ||
| commit message format is in effect for the project. Please try to adhere to it. Here are | ||
| Finally, commit your changes to your local repository with an explanatory message. *Pandas* uses | ||
| the following convention for commit messages...please try to adhere to it. Here are |
There was a problem hiding this comment.
Was "messages...please" the intention? (looks a bit strange)
|
Very minor comment, looks very good for the rest! |
DOC: Note on PyTables index issue and additional Contributing refinements
|
@rockg thanks! |
closes #9676