DOC: use _shared_docs for fillna methods #10036
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -34,7 +34,7 @@ | |||
| _shared_doc_kwargs = dict( | |||
| axes='items, major_axis, minor_axis', | |||
| klass="Panel", | |||
| axes_single_arg="{0,1,2,'items','major_axis','minor_axis'}") | |||
There was a problem hiding this comment.
I think this shouldn't be changed, because the name is used in __init__ keyword?
There was a problem hiding this comment.
oh ... indeed, this probably shouldn't be changed, i'll update
mortada
force-pushed
the
fillna_shared_docs
branch
from
bf10a74 to
ec38d71
Compare
|
@sinhrks updated according to your comments |
jreback
added a commit
that referenced
this pull request
May 4, 2015
DOC: use _shared_docs for fillna methods
|
@mortada thanks you sir! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently the docstring for
DataFrame.fillnais shown forSeries.fillnaandPanel.fillna. http://pandas.pydata.org/pandas-docs/version/0.16.0/generated/pandas.Panel.fillna.html?highlight=fillna#pandas.Panel.fillnathis is not accurate in particular for the
axisvalues. This PR makes it such that they share the same template with differentaxisdescriptions.