Skip to content

DOC: use _shared_docs for fillna methods #10036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 4, 2015

Conversation

mortada
Copy link
Contributor

@mortada mortada commented Apr 30, 2015

currently the docstring for DataFrame.fillna is shown for Series.fillna and Panel.fillna. http://pandas.pydata.org/pandas-docs/version/0.16.0/generated/pandas.Panel.fillna.html?highlight=fillna#pandas.Panel.fillna

this is not accurate in particular for the axis values. This PR makes it such that they share the same template with different axis descriptions.

@@ -34,7 +34,7 @@
_shared_doc_kwargs = dict(
axes='items, major_axis, minor_axis',
klass="Panel",
axes_single_arg="{0,1,2,'items','major_axis','minor_axis'}")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this shouldn't be changed, because the name is used in __init__ keyword?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh ... indeed, this probably shouldn't be changed, i'll update

@sinhrks sinhrks added the Docs label May 1, 2015
@sinhrks sinhrks added this to the 0.16.1 milestone May 1, 2015
@mortada mortada force-pushed the fillna_shared_docs branch from bf10a74 to ec38d71 Compare May 1, 2015 18:42
@mortada
Copy link
Contributor Author

mortada commented May 1, 2015

@sinhrks updated according to your comments

jreback added a commit that referenced this pull request May 4, 2015
DOC: use _shared_docs for fillna methods
@jreback jreback merged commit 5db35d0 into pandas-dev:master May 4, 2015
@jreback
Copy link
Contributor

jreback commented May 4, 2015

@mortada thanks you sir!

@mortada mortada deleted the fillna_shared_docs branch May 5, 2015 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants