BUG: null group spills into final group when grouping on a categorical #10014
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| starts[lab] = start | ||
| ends[lab] = start + group_size | ||
| start += group_size | ||
| group_size = 0 | ||
|
|
There was a problem hiding this comment.
The null group is represented with a label of -1, so it was getting put in the final spot of starts / ends. In the usual case, it would then get overwritten by the last group, but when grouping on a categorical, the last group may be empty.
|
looks good, ping when green. |
shoyer
added a commit
that referenced
this pull request
Apr 29, 2015
BUG: null group spills into final group when grouping on a categorical
|
thanks @evanpw ! |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes GH #9603