-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
Non-unique column names in fixed format HDF5 #7761
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
can u put up an example for the tests |
Only the last call fails with an It can be fixed by adding a check for the uniqueness of the column index in the fixed format. Note that this problem does not occur for the table format. |
perfect. want to do a PR to validate and raise ValueError (could also be NotImplementedError) on writing? |
I'll build one with tests, yes. Is it enough to fix this in |
@filmor I believe so. Put in a test with |
This leads to an error on read, writing is possible however. Since the format has a fundamental problem with this case if there are columns with the same name but different data types this is not fixable.
However,
df.to_hdf
should just not write the respective dataframe if the column index is not unique.The text was updated successfully, but these errors were encountered: