Skip to content

API: Index.insert too much dtype inference #51363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jbrockmendel opened this issue Feb 13, 2023 · 0 comments · Fixed by #55257
Closed

API: Index.insert too much dtype inference #51363

jbrockmendel opened this issue Feb 13, 2023 · 0 comments · Fixed by #55257
Labels
Bug Dtype Conversions Unexpected or buggy dtype conversions Index Related to the Index class or subclasses

Comments

@jbrockmendel
Copy link
Member

jbrockmendel commented Feb 13, 2023 •
edited
Loading 

idx = pd.Index([1], dtype=object)

idx.insert(0, 1).dtype

ATM Index.insert uses Index._with_infer to construct a result, which will cast the case here to int64 instead of retaining object. I think in this case it would be more reasonable to keep object dtype, which we'd get by just calling Index.__new__ instead of _with_infer.

We have no tests that depend on this ATM.
@jbrockmendel jbrockmendel added Bug Needs Triage Issue that has not been reviewed by a pandas team member labels Feb 13, 2023
@phofl phofl added Dtype Conversions Unexpected or buggy dtype conversions Index Related to the Index class or subclasses and removed Needs Triage Issue that has not been reviewed by a pandas team member labels Feb 23, 2023
@jbrockmendel jbrockmendel mentioned this issue Apr 19, 2023
Closed
3 tasks
@jbrockmendel jbrockmendel mentioned this issue Sep 23, 2023
Merged
5 tasks
@jbrockmendel jbrockmendel mentioned this issue Nov 16, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Dtype Conversions Unexpected or buggy dtype conversions Index Related to the Index class or subclasses
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

DEPR: Index.insert dtype-inference jbrockmendel/pandas
2 participants
@jbrockmendel @phofl