Skip to content

TST: sometimes failing ujson comparison #4575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jreback opened this issue Aug 15, 2013 · 5 comments · Fixed by #4592
Closed

TST: sometimes failing ujson comparison #4575

jreback opened this issue Aug 15, 2013 · 5 comments · Fixed by #4592
Labels
Testing pandas testing functions or related to the test suite
Milestone

Comments

@jreback
Copy link
Contributor

jreback commented Aug 15, 2013

cc @Komnomnomnom

skipping test via: b5ff81d

fails about 1/3 times (and only seems on py3)

https://travis-ci.org/pydata/pandas/jobs/10223886

don't use now, pick a known value (that you can then compare too exactly)

  def test_datetime_units(self):
        from pandas.lib import Timestamp

        val = datetime.datetime.now()
        stamp = Timestamp(val)
@Komnomnomnom
Copy link
Contributor

Hmm I'll take a look, is this only on Python 3?

@jreback
Copy link
Contributor Author

jreback commented Aug 15, 2013

I only had it fail on py3 as well; maybe the division is not comparing correctly..(should be truediv)

in any even pick a time that has non-zero comparsion values and do the same type of comparison

@jreback
Copy link
Contributor Author

jreback commented Aug 15, 2013

it doesn't always fail, that's what is weird....this is rebased on master: https://travis-ci.org/jreback/pandas/builds/10224858

run on py3, and put it in a loop until it fails then import debugger at that point

@Komnomnomnom
Copy link
Contributor

Ok will do. I won't be able to look into this for a while, so if you want to comment out the test etc so the master branch is ok for now then feel free.

@jreback
Copy link
Contributor Author

jreback commented Aug 15, 2013

ok....skipped for now...come back to it when you can

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants