Skip to content

test_time_series_plot_color_with_empty_kwargs fails with custom matplotlibrc #4345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nfoti opened this issue Jul 24, 2013 · 3 comments · Fixed by #4360
Closed

test_time_series_plot_color_with_empty_kwargs fails with custom matplotlibrc #4345

nfoti opened this issue Jul 24, 2013 · 3 comments · Fixed by #4360
Labels
Testing pandas testing functions or related to the test suite Visualization plotting
Milestone
0.13

Comments

@nfoti
Copy link
Contributor

nfoti commented Jul 24, 2013

The reason is that it tests for particular line colors, but I have my matplotlib colors tweaked, so the default values aren't r, g, and b. The test should probably look at the default color_cycle in matplotlib and check against those values.
@cpcloud
Copy link
Member

cpcloud commented Jul 24, 2013

Should be a simple fix then. Want to submit a PR? Happy to help u get setup with that if necessary.

@jtratner
Copy link
Contributor

Another option is explicitly set any properties programmatically in setUpClass/setUp, e.g. using matplotlib.rcParams

@nfoti nfoti mentioned this issue Jul 25, 2013
Merged
@nfoti
Copy link
Contributor Author

nfoti commented Jul 25, 2013

Submitted PR #4360 which fixes this.

On Wed, Jul 24, 2013 at 4:57 PM, Jeff Tratner [email protected]:

Another option is explicitly set any properties programmatically in
setUpClass/setUp, e.g. using matplotlib.rcParams

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/4345#issuecomment-21515573
.

nfoti added a commit to nfoti/pandas that referenced this issue Jul 30, 2013
@nfoti
Fixed issue pandas-dev#4345.
fac519b
cpcloud added a commit that referenced this issue Jul 30, 2013
@cpcloud
Merge pull request #4360 from nfoti/master
cc9bff6 
Fix issue #4345: graphics test failure
mortada pushed a commit to mortada/pandas that referenced this issue Aug 9, 2013
@nfoti
Fixed issue pandas-dev#4345.
5363806
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Testing pandas testing functions or related to the test suite Visualization plotting
Projects
None yet
Milestone
0.13
Development

Successfully merging a pull request may close this issue.

Fix issue #4345: graphics test failure nfoti/pandas
3 participants
@cpcloud @nfoti @jtratner