Skip to content

DOC: add additional numba example #35550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
raybellwaves opened this issue Aug 4, 2020 · 10 comments · Fixed by #35778
Closed

DOC: add additional numba example #35550

raybellwaves opened this issue Aug 4, 2020 · 10 comments · Fixed by #35778
Assignees
Labels
Docs good first issue Window rolling, ewma, expanding
Milestone

Comments

@raybellwaves
Copy link
Contributor

Location of the documentation

https://pandas.pydata.org/pandas-docs/stable/user_guide/enhancingperf.html#using-numba

Documentation problem

Provide a simpler copy-paste example.

Suggested fix for documentation

@TomAugspurger has a nice example of using numba to speed up a rolling.apply() operation here https://github.com/TomAugspurger/acon-2020-pandas/blob/master/Numba%20Acceleration.ipynb

Could this or a variant of this be added to the docs? Perhaps to show that you don't need to do import numba but can do engine='numba'

@raybellwaves raybellwaves added Docs Needs Triage Issue that has not been reviewed by a pandas team member labels Aug 4, 2020
@TomAugspurger
Copy link
Contributor

TomAugspurger commented Aug 4, 2020 via email

@raybellwaves
Copy link
Contributor Author

@simonjayhawkins simonjayhawkins removed the Needs Triage Issue that has not been reviewed by a pandas team member label Aug 5, 2020
@simonjayhawkins simonjayhawkins added this to the Contributions Welcome milestone Aug 5, 2020
@reubence
Copy link

reubence commented Aug 12, 2020

May I take up this issue?

@vaibhavarora102
Copy link

sir, can I work on this

@erfannariman
Copy link
Member

take

@TomAugspurger
Copy link
Contributor

TomAugspurger commented Aug 17, 2020 via email

@erfannariman
Copy link
Member

Didnt want to remove comment, wanted to edit. Thanks for reply @TomAugspurger

@vaibhavarora102
Copy link

@TomAugspurger kindly tell I could contribute in any way, as I am new to open source
thanks!

@TomAugspurger
Copy link
Contributor

TomAugspurger commented Aug 18, 2020 via email

@vaibhavarora102
Copy link

Thanks alot

@jreback jreback modified the milestones: Contributions Welcome, 1.2 Aug 19, 2020
@jreback jreback added the Window rolling, ewma, expanding label Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docs good first issue Window rolling, ewma, expanding
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants