Skip to content

Windowing fails on read-only arrays #27766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kernc opened this issue Aug 6, 2019 · 0 comments · Fixed by #27767
Closed

Windowing fails on read-only arrays #27766

kernc opened this issue Aug 6, 2019 · 0 comments · Fixed by #27767
Labels
Bug Window rolling, ewma, expanding
Milestone

Comments

@kernc
Copy link
Contributor

kernc commented Aug 6, 2019

Code Sample, a copy-pastable example if possible

>>> arr = np.array([1, 3, np.nan, 3, 5])
>>> arr.setflags(write=False)
>>> pd.Series(arr).rolling(2).mean().values
---------------------------------------------------------------------------
ValueError: assignment destination is read-only

Expected Output

>>> pd.Series(arr).rolling(2).mean().values
array([nan,  2., nan, nan,  4.])

Problem description

#27391 (comment) missed a copy call before writing into array, which is user's data and which may be read-only.

Output of pd.show_versions()

pandas 0.25.0

@jreback jreback added Bug Window rolling, ewma, expanding labels Aug 6, 2019
@jreback jreback added this to the 0.25.1 milestone Aug 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Window rolling, ewma, expanding
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants