Skip to content

Misleading "not" typo in assertion in pandas.concat in join_axes check #23204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Ignalion opened this issue Oct 17, 2018 · 2 comments · Fixed by #23221
Closed

Misleading "not" typo in assertion in pandas.concat in join_axes check #23204

Ignalion opened this issue Oct 17, 2018 · 2 comments · Fixed by #23221
Labels
Error Reporting Incorrect or improved errors from pandas good first issue
Milestone

Comments

@Ignalion
Copy link

There is an assertion message in concat.py:

            if len(self.join_axes) != ndim - 1:
                raise AssertionError("length of join_axes must not be equal "
                                     "to {length}".format(length=ndim - 1))

From code (and from it's usage) it's obvious that word "not" is incorrect here and should be deleted.

@TomAugspurger TomAugspurger added Error Reporting Incorrect or improved errors from pandas Effort Low good first issue labels Oct 18, 2018
@TomAugspurger
Copy link
Contributor

Thanks for the report. Interested in submitting a PR fixing it?

@TomAugspurger TomAugspurger added this to the Contributions Welcome milestone Oct 18, 2018
@rdmontgomery
Copy link
Contributor

Hi there. I submitted a PR to remove the "not" from the assertion message. This is my first contribution to pandas! Happy to follow up if I missed anything in the process.

@jreback jreback modified the milestones: Contributions Welcome, 0.24.0 Oct 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Error Reporting Incorrect or improved errors from pandas good first issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants