Skip to content

CLN: Remove unused code in groupby.py #20456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
WillAyd opened this issue Mar 22, 2018 · 0 comments · Fixed by #20457
Closed

CLN: Remove unused code in groupby.py #20456

WillAyd opened this issue Mar 22, 2018 · 0 comments · Fixed by #20457
Labels
Clean Groupby Refactor Internal refactoring of code
Milestone

Comments

@WillAyd
Copy link
Member

WillAyd commented Mar 22, 2018

williams-mbp:pandas williamayd$ vulture pandas | grep "pandas/core/groupby.py"
pandas/core/groupby.py:947: unused function '_index_with_as_index' (60% confidence)
pandas/core/groupby.py:2280: unused function '_max_groupsize' (60% confidence)
pandas/core/groupby.py:2927: unused attribute '_should_compress' (60% confidence)
pandas/core/groupby.py:4940: unused class 'NDArrayGroupBy' (60% confidence)
pandas/core/groupby.py:4996: unused class 'ArraySplitter' (60% confidence)

Grepping the pandas directory for these items individual yields no uses outside of their initial declaration. Should be safe to remove and start cleaning up the module

@TomAugspurger TomAugspurger added Refactor Internal refactoring of code Clean labels Mar 22, 2018
@TomAugspurger TomAugspurger added this to the 0.23.0 milestone Mar 22, 2018
@TomAugspurger TomAugspurger modified the milestones: 0.23.0, Next Major Release Mar 22, 2018
@jreback jreback modified the milestones: Next Major Release, 0.23.0 Mar 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Clean Groupby Refactor Internal refactoring of code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants