Doc build leaves behind a test.json file

[TomAugspurger]

I think from

pandas/doc/source/whatsnew/v0.23.0.txt

Line 220 in aa59954

print(new_df.index.name)

.

It should be removed in a hidden ipython block afterwards.

.. ipython:: python
   :suppress:

   import os
   os.remove('test.json')

[gfyoung]

@TomAugspurger : Alternatively, you can write to an IO object (instead of an actual file) and then read that instead (no cleanup needed afterwards).

[TomAugspurger]

I think for newcomers writing to a path is more approachable than using an `io.TextIO` buffer.

…

On Wed, Feb 21, 2018 at 11:35 AM, gfyoung ***@***.***> wrote: @TomAugspurger <https://github.com/tomaugspurger> : Alternatively, you can write to an IO object (instead of an actual file) and then read that instead (no cleanup needed afterwards). — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#19815 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABQHItXSh2_fiJjd8VY9ro5VkyQdWKFqks5tXFP7gaJpZM4SN1k1> .

[gfyoung]

Sure, but I'm thinking about if that's the best way to do it (meaning it might not be newcomer-friendly). Mind you that os.remove is not the nicest of things on Windows, so if users try to build docs there, that could be problematic.

[TomAugspurger]

I wasn't aware of that. We use it elsewhere in the docs and I haven't seen any issues reported.

…

On Wed, Feb 21, 2018 at 12:19 PM, gfyoung ***@***.***> wrote: Sure, but I'm thinking about whether that's the best way to do it (meaning it might not be newcomer-friendly). Mind you that os.remove is not the nicest of things on Windows, so if users try to build docs there, that could be problematic. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#19815 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABQHIkNvDEOHbi7_w1WsNDBDphM2J2jrks5tXF4XgaJpZM4SN1k1> .

[gfyoung]

That's fair. If this is just a one-off patch (i.e. we cleanup files elsewhere I presume), then I suppose adding this clean-up is fine then. I'm still personally in the IO object camp, but not going to fight over one simple use case in the docs. 😄

[jjames34]

I'm taking this on for HackIllinois!