Skip to content

CI: NumPy is being upgraded #18992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
TomAugspurger opened this issue Dec 29, 2017 · 3 comments · Fixed by #18995
Closed

CI: NumPy is being upgraded #18992

TomAugspurger opened this issue Dec 29, 2017 · 3 comments · Fixed by #18995
Labels
CI Continuous Integration

Comments

@TomAugspurger
Copy link
Contributor

Looks like NumPy is being upgraded behind our back on master: https://travis-ci.org/pandas-dev/pandas/jobs/322904433#L1313

That's what's causing the failures on the 0.22 backports branch. Master is currently failing with NumPy 1.10, but we aren't catching it.

I'll look into it now.

cc @jreback

@TomAugspurger TomAugspurger added the CI Continuous Integration label Dec 29, 2017
@TomAugspurger
Copy link
Contributor Author

I may just use this issue for fixing the test failures in https://travis-ci.org/pandas-dev/pandas/jobs/322911128#L1783

At the moment this seem to be related issues seem to be https://github.com/numpy/numpy /pull/8231 and #15363 (power of integer array to integer array). This test is skipped on NumPy>=1.12

(Pdb) df.A.values[:5]
array([17, 92, 17, 79, 54])
(Pdb) other.A.values[:5]
array([17, 92, 17, 79, 54])
(Pdb) df.A.values[:5] ** other.A.values[:5]
array([-9223372036854775808, -9223372036854775808, -9223372036854775808,
       -9223372036854775808, -9223372036854775808])

So I'm tempted to just remove pow from that test.

jreback added a commit to jreback/pandas that referenced this issue Dec 29, 2017
@jreback
Copy link
Contributor

jreback commented Dec 29, 2017

oh, yes we DO skip on pow in test_binary_ops already (though its hacky). prob same issue. my fix is too extreme.

@TomAugspurger
Copy link
Contributor Author

Yeah, it's just pow. Opened #18995 so that it's easy to backport.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration
Projects
None yet
2 participants