Skip to content

Travis build fails on master #12240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nbonnotte opened this issue Feb 6, 2016 · 6 comments
Closed

Travis build fails on master #12240

nbonnotte opened this issue Feb 6, 2016 · 6 comments
Labels
Testing pandas testing functions or related to the test suite

Comments

@nbonnotte
Copy link
Contributor

https://travis-ci.org/pydata/pandas/builds/107252660

This happens since the last commit, which was merging a pull request of mine... but Travis was green for me, and beside I can't see no connection between that:


ERROR: test_nankurt (pandas.tests.test_nanops.TestnanopsDataFrame)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/travis/build/pydata/pandas/pandas/tests/test_nanops.py", line 141, in check_results
    tm.assert_almost_equal(targ, res)
  File "pandas/src/testing.pyx", line 58, in pandas._testing.assert_almost_equal (pandas/src/testing.c:3809)
    cpdef assert_almost_equal(a, b, bint check_less_precise=False,
  File "pandas/src/testing.pyx", line 156, in pandas._testing.assert_almost_equal (pandas/src/testing.c:2830)
    raise_assert_detail(obj, msg, a, b)
  File "/home/travis/build/pydata/pandas/pandas/util/testing.py", line 842, in raise_assert_detail
    raise AssertionError(msg)
AssertionError: Iterable are different
Second object is iterable, first isn't
[left]:  nan
[right]: [[nan, nan, nan, nan, nan], [nan, nan, nan, nan, nan], [nan, nan, nan, nan, nan], [nan, nan, nan, nan, nan], [nan, nan, nan, nan, nan], [nan, nan, nan, nan, nan], [nan, nan, nan, nan, nan]]

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/travis/build/pydata/pandas/pandas/tests/test_nanops.py", line 453, in test_nankurt
    allow_str=False, allow_date=False, allow_tdelta=False)
  File "/home/travis/build/pydata/pandas/pandas/tests/test_nanops.py", line 233, in check_funs
    **kwargs)
  File "/home/travis/build/pydata/pandas/pandas/tests/test_nanops.py", line 222, in check_fun
    targarnanval, **kwargs)
  File "/home/travis/build/pydata/pandas/pandas/tests/test_nanops.py", line 184, in check_fun_data
    self.check_results(targ, res, axis)
  File "/home/travis/build/pydata/pandas/pandas/tests/test_nanops.py", line 144, in check_results
    if targ.dtype == 'm8[ns]':
AttributeError: ("'float' object has no attribute 'dtype'", 'axis: 0 of 2', 'skipna: False', 'kwargs: {}', 'testar: arr_float_nan', 'targar: arr_float', 'targarnan: arr_float_nan')

and my commit, which was about the formatting of float strings.

@TomAugspurger
Copy link
Contributor

Looks like it's a Scipy issue. Jeff has a PR here #12239.

This happens since the last commit, which was merging a pull request of mine

Always a good feeling when your not the one who broke it!

@TomAugspurger
Copy link
Contributor

Ahh maybe I closed this too soon. Jeff's PR doesn't handle the nanops. Should we skip those for now (at least on Scipy 0.17)? It'd be good to get things passing again.

@TomAugspurger TomAugspurger reopened this Feb 6, 2016
@jreback
Copy link
Contributor

jreback commented Feb 6, 2016

yeah we should skip the failing parts for now
but of course fix them in another tissue
i think scipy fixed some bugs

@TomAugspurger
Copy link
Contributor

OK, I'll see if I can fix the tests. Assumed they were new bugs from scipy, not fixes.

@TomAugspurger
Copy link
Contributor

Oh my, these tests are complicated :) This is the change in scipy I believe. Still trying to work out what changed... Maybe I'll put up a PR with skipifs for now :)

jreback pushed a commit that referenced this issue Feb 6, 2016
Working around #12240 which
we'll leave open until I (or someone more knowledgeable) can properly
fix these.    This skips the following tests when on scipy 0.17    -
test_nansem  - test_nanskew  - test_nankurk

Author: Tom Augspurger <[email protected]>

Closes #12243 from TomAugspurger/scipy0.17 and squashes the following commits:

af7039a [Tom Augspurger] TST: Skip scipy NaN test on 0.17 for now
@jreback
Copy link
Contributor

jreback commented Feb 6, 2016

dupe of #12235

@jreback jreback closed this as completed Feb 6, 2016
@jreback jreback added the Testing pandas testing functions or related to the test suite label Feb 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Testing pandas testing functions or related to the test suite
Projects
None yet
Development

No branches or pull requests

3 participants