STYLE: fix pylint: no-else-raise (#49520)

* fix pylint: no-else-raise

* fix possible imbalanced tuple unpacking warning

Co-authored-by: carlotta <[email protected]>

Author: fabinca

ci/fix_wheels.py

@@ -4,7 +4,12 @@
 import zipfile
 
 try:
-    _, wheel_path, dest_dir = sys.argv
+    if len(sys.argv) != 3:
+        raise ValueError(
+            "User must pass the path to the wheel and the destination directory."
+        )
+    wheel_path = sys.argv[1]
+    dest_dir = sys.argv[2]
     # Figure out whether we are building on 32 or 64 bit python
     is_32 = sys.maxsize <= 2**32
     PYTHON_ARCH = "x86" if is_32 else "x64"
@@ -50,5 +55,4 @@
 if not success:
     os.remove(repaired_wheel_path)
     raise exception
-else:
-    print(f"Successfully repaired wheel was written to {repaired_wheel_path}")
+print(f"Successfully repaired wheel was written to {repaired_wheel_path}")

doc/make.py

@@ -259,8 +259,7 @@ def latex(self, force=False):
                     "You should check the file "
                     '"build/latex/pandas.pdf" for problems.'
                 )
-            else:
-                self._run_os("make")
+            self._run_os("make")
             return ret_code
 
     def latex_forced(self):

pandas/_testing/_io.py

@@ -243,10 +243,7 @@ def wrapper(*args, **kwargs):
 
             if not isinstance(err, error_classes) or raise_on_error:
                 raise
-            else:
-                pytest.skip(
-                    f"Skipping test due to lack of connectivity and error {err}"
-                )
+            pytest.skip(f"Skipping test due to lack of connectivity and error {err}")
 
     return wrapper
 

pandas/compat/_optional.py

@@ -141,8 +141,7 @@ def import_optional_dependency(
     except ImportError:
         if errors == "raise":
             raise ImportError(msg)
-        else:
-            return None
+        return None
 
     # Handle submodules: if we have submodule, grab parent module from sys.modules
     parent = name.split(".")[0]

pandas/compat/numpy/function.py

@@ -412,8 +412,7 @@ def validate_resampler_func(method: str, args, kwargs) -> None:
                 "numpy operations are not valid with resample. "
                 f"Use .resample(...).{method}() instead"
             )
-        else:
-            raise TypeError("too many arguments passed in")
+        raise TypeError("too many arguments passed in")
 
 
 def validate_minmax_axis(axis: AxisInt | None, ndim: int = 1) -> None:

pandas/conftest.py

@@ -1163,8 +1163,7 @@ def deco(*args):
                 raise ValueError(
                     f"Could not find file {path} and --strict-data-files is set."
                 )
-            else:
-                pytest.skip(f"Could not find {path}.")
+            pytest.skip(f"Could not find {path}.")
         return path
 
     return deco

pandas/core/apply.py

@@ -464,7 +464,7 @@ def apply_str(self) -> DataFrame | Series:
                 "axis" not in arg_names or f in ("corrwith", "skew")
             ):
                 raise ValueError(f"Operation {f} does not support axis=1")
-            elif "axis" in arg_names:
+            if "axis" in arg_names:
                 self.kwargs["axis"] = self.axis
         return self._try_aggregate_string_function(obj, f, *self.args, **self.kwargs)
 
@@ -762,7 +762,7 @@ def apply_broadcast(self, target: DataFrame) -> DataFrame:
             # must be a scalar or 1d
             if ares > 1:
                 raise ValueError("too many dims to broadcast")
-            elif ares == 1:
+            if ares == 1:
 
                 # must match return dim
                 if result_compare != len(res):
@@ -1179,7 +1179,7 @@ def reconstruct_func(
                 "Function names must be unique if there is no new column names "
                 "assigned"
             )
-        elif func is None:
+        if func is None:
             # nicer error message
             raise TypeError("Must provide 'func' or tuples of '(column, aggfunc).")
 

pandas/core/arrays/datetimelike.py

@@ -2263,7 +2263,7 @@ def validate_inferred_freq(
                 "values does not conform to passed frequency "
                 f"{freq.freqstr}"
             )
-        elif freq is None:
+        if freq is None:
             freq = inferred_freq
         freq_infer = False
 

pandas/core/arrays/datetimes.py

@@ -2361,7 +2361,7 @@ def validate_tz_from_dtype(
         if dtz is not None:
             if tz is not None and not timezones.tz_compare(tz, dtz):
                 raise ValueError("cannot supply both a tz and a dtype with a tz")
-            elif explicit_tz_none:
+            if explicit_tz_none:
                 raise ValueError("Cannot pass both a timezone-aware dtype and tz=None")
             tz = dtz
 

pandas/core/arrays/interval.py

@@ -314,17 +314,17 @@ def _simple_new(
                 f"right [{type(right).__name__}] types"
             )
             raise ValueError(msg)
-        elif is_categorical_dtype(left.dtype) or is_string_dtype(left.dtype):
+        if is_categorical_dtype(left.dtype) or is_string_dtype(left.dtype):
             # GH 19016
             msg = (
                 "category, object, and string subtypes are not supported "
                 "for IntervalArray"
             )
             raise TypeError(msg)
-        elif isinstance(left, ABCPeriodIndex):
+        if isinstance(left, ABCPeriodIndex):
             msg = "Period dtypes are not supported, use a PeriodIndex instead"
             raise ValueError(msg)
-        elif isinstance(left, ABCDatetimeIndex) and str(left.tz) != str(right.tz):
+        if isinstance(left, ABCDatetimeIndex) and str(left.tz) != str(right.tz):
             msg = (
                 "left and right must have the same time zone, got "
                 f"'{left.tz}' and '{right.tz}'"
@@ -1321,7 +1321,7 @@ def mid(self) -> Index:
     def overlaps(self, other):
         if isinstance(other, (IntervalArray, ABCIntervalIndex)):
             raise NotImplementedError
-        elif not isinstance(other, Interval):
+        if not isinstance(other, Interval):
             msg = f"`other` must be Interval-like, got {type(other).__name__}"
             raise TypeError(msg)