Lint, move whatsnew, remove hardcoded Monday, check that get_locale is None

Author: mroeschke

doc/source/whatsnew/v0.21.1.txt

@@ -22,7 +22,7 @@ Other Enhancements
 ^^^^^^^^^^^^^^^^^^
 
 - :meth:`Timestamp.timestamp` is now available in Python 2.7. (:issue:`17329`)
-- :attr:`Timestamp.month_name`, :attr:`DatetimeIndex.month_name`, and :attr:`Series.dt.month_name` are now available (:issue:`12805`)
+-
 -
 
 .. _whatsnew_0211.deprecations:
@@ -65,7 +65,7 @@ Bug Fixes
 Conversion
 ^^^^^^^^^^
 
-- Bug in :attr:`Timestamp.weekday_name` and :attr:`DatetimeIndex.weekday_name` not returning locale aware values (:issue:`12806`)
+-
 -
 -
 

doc/source/whatsnew/v0.22.0.txt

@@ -23,7 +23,7 @@ Other Enhancements
 ^^^^^^^^^^^^^^^^^^
 
 - Better support for ``Dataframe.style.to_excel()`` output with the ``xlsxwriter`` engine. (:issue:`16149`)
--
+- :attr:`Timestamp.month_name`, :attr:`DatetimeIndex.month_name`, and :attr:`Series.dt.month_name` are now available (:issue:`12805`)
 -
 
 .. _whatsnew_0220.api_breaking:
@@ -94,7 +94,7 @@ Bug Fixes
 Conversion
 ^^^^^^^^^^
 
--
+- Bug in :attr:`Timestamp.weekday_name` and :attr:`DatetimeIndex.weekday_name` not returning locale aware values (:issue:`12806`)
 -
 -
 

pandas/_libs/tslibs/fields.pyx

@@ -30,6 +30,7 @@ cdef int64_t NPY_NAT = util.get_nat()
 
 from pandas._libs.tslibs.strptime import LocaleTime
 
+
 def build_field_sarray(ndarray[int64_t] dtindex):
     """
     Datetime as int64 representation to a structured array of fields

pandas/tests/indexes/datetimes/test_misc.py

@@ -328,7 +328,7 @@ def test_datetimeindex_accessors(self):
         assert [d.weekofyear for d in dates] == expected
 
     # GH 12806
-    @pytest.mark.skipif(len(tm.get_locales()) == 0,
+    @pytest.mark.skipif(tm.get_locales() is None or len(tm.get_locales()) == 0,
                         reason='No available locales')
     @pytest.mark.parametrize('time_locale', tm.get_locales())
     def test_datetime_name_accessors(self, time_locale):

pandas/tests/scalar/test_timestamp.py

@@ -1,6 +1,7 @@
 """ test the scalar Timestamp """
 
 import sys
+import locale
 import pytz
 import pytest
 import dateutil
@@ -597,13 +598,17 @@ def check(value, equal):
         for end in ends:
             assert getattr(ts, end)
 
-    @pytest.mark.parametrize('data, expected',
-                             [(Timestamp('2017-08-28 23:00:00'), 'Monday'),
-                              (Timestamp('2017-08-28 23:00:00', tz='EST'),
-                               'Monday')])
-    def test_weekday_name(self, data, expected):
+    # GH 12806
+    @pytest.mark.skipif(tm.get_locales() is None or len(tm.get_locales()) == 0,
+                        reason='No available locales')
+    @pytest.mark.parametrize('data',
+                             [Timestamp('2017-08-28 23:00:00'),
+                              Timestamp('2017-08-28 23:00:00', tz='EST')])
+    @pytest.mark.parametrize('time_locale', tm.get_locales())
+    def test_weekday_name(self, data, time_locale):
         # GH 17354
-        assert data.weekday_name == expected
+        with tm.set_locale(time_locale, locale.LC_TIME):
+            assert data.weekday_name == calendar.day_name[0].capitalize()
 
     def test_pprint(self):
         # GH12622