CI: fix flake C413, C414, C416 errors (#29646)

Author: simonjayhawkins

.pre-commit-config.yaml

@@ -9,7 +9,7 @@ repos:
     hooks:
     -   id: flake8
         language: python_venv
-        additional_dependencies: [flake8-comprehensions]
+        additional_dependencies: [flake8-comprehensions>=3.1.0]
 -   repo: https://github.com/pre-commit/mirrors-isort
     rev: v4.3.20
     hooks:

asv_bench/benchmarks/categoricals.py

@@ -164,7 +164,7 @@ def setup(self, dtype):
         np.random.seed(1234)
         n = 5 * 10 ** 5
         sample_size = 100
-        arr = [i for i in np.random.randint(0, n // 10, size=n)]
+        arr = list(np.random.randint(0, n // 10, size=n))
         if dtype == "object":
             arr = [f"s{i:04d}" for i in arr]
         self.sample = np.random.choice(arr, sample_size)

asv_bench/benchmarks/frame_ctor.py

@@ -99,7 +99,7 @@ class FromLists:
     def setup(self):
         N = 1000
         M = 100
-        self.data = [[j for j in range(M)] for i in range(N)]
+        self.data = [list(range(M)) for i in range(N)]
 
     def time_frame_from_lists(self):
         self.df = DataFrame(self.data)

doc/source/whatsnew/v0.24.0.rst

@@ -353,7 +353,7 @@ Example:
 
     mi = pd.MultiIndex.from_product([list('AB'), list('CD'), list('EF')],
                                     names=['AB', 'CD', 'EF'])
-    df = pd.DataFrame([i for i in range(len(mi))], index=mi, columns=['N'])
+    df = pd.DataFrame(list(range(len(mi))), index=mi, columns=['N'])
     df
     df.rename_axis(index={'CD': 'New'})
 

environment.yml

@@ -18,7 +18,7 @@ dependencies:
   - black<=19.3b0
   - cpplint
   - flake8
-  - flake8-comprehensions  # used by flake8, linting of unnecessary comprehensions
+  - flake8-comprehensions>=3.1.0  # used by flake8, linting of unnecessary comprehensions
   - flake8-rst>=0.6.0,<=0.7.0  # linting of code blocks in rst files
   - isort  # check that imports are in the right order
   - mypy=0.720

pandas/core/arrays/categorical.py

@@ -1110,7 +1110,7 @@ def remove_categories(self, removals, inplace=False):
         if not is_list_like(removals):
             removals = [removals]
 
-        removal_set = set(list(removals))
+        removal_set = set(removals)
         not_included = removal_set - set(self.dtype.categories)
         new_categories = [c for c in self.dtype.categories if c not in removal_set]
 

pandas/core/arrays/sparse/scipy_sparse.py

@@ -51,7 +51,7 @@ def _get_label_to_i_dict(labels, sort_labels=False):
             """
             labels = Index(map(tuple, labels)).unique().tolist()  # squish
             if sort_labels:
-                labels = sorted(list(labels))
+                labels = sorted(labels)
             d = OrderedDict((k, i) for i, k in enumerate(labels))
             return d
 

pandas/core/frame.py

@@ -4281,7 +4281,7 @@ def set_index(
         arrays = []
         names = []
         if append:
-            names = [x for x in self.index.names]
+            names = list(self.index.names)
             if isinstance(self.index, ABCMultiIndex):
                 for i in range(self.index.nlevels):
                     arrays.append(self.index._get_level_values(i))
@@ -7268,7 +7268,7 @@ def _series_round(s, decimals):
             if isinstance(decimals, Series):
                 if not decimals.index.is_unique:
                     raise ValueError("Index of decimals must be unique")
-            new_cols = [col for col in _dict_round(self, decimals)]
+            new_cols = list(_dict_round(self, decimals))
         elif is_integer(decimals):
             # Dispatch to Series.round
             new_cols = [_series_round(v, decimals) for _, v in self.items()]

pandas/core/indexes/multi.py

@@ -368,7 +368,7 @@ def _verify_integrity(self, codes=None, levels=None):
             if not level.is_unique:
                 raise ValueError(
                     "Level values must be unique: {values} on "
-                    "level {level}".format(values=[value for value in level], level=i)
+                    "level {level}".format(values=list(level), level=i)
                 )
         if self.sortorder is not None:
             if self.sortorder > self._lexsort_depth():
@@ -1992,8 +1992,8 @@ def levshape(self):
     def __reduce__(self):
         """Necessary for making this object picklable"""
         d = dict(
-            levels=[lev for lev in self.levels],
-            codes=[level_codes for level_codes in self.codes],
+            levels=list(self.levels),
+            codes=list(self.codes),
             sortorder=self.sortorder,
             names=list(self.names),
         )

pandas/core/internals/managers.py

@@ -260,7 +260,7 @@ def get_ftypes(self):
     def __getstate__(self):
         block_values = [b.values for b in self.blocks]
         block_items = [self.items[b.mgr_locs.indexer] for b in self.blocks]
-        axes_array = [ax for ax in self.axes]
+        axes_array = list(self.axes)
 
         extra_state = {
             "0.14.1": {