Backport PR #38638: BUG: Fix regression in pandas merge (#38639)

Co-authored-by: patrick <[email protected]>

Author: meeseeksmachine

pandas/core/reshape/merge.py

@@ -859,7 +859,7 @@ def _maybe_add_join_keys(self, result, left_indexer, right_indexer):
                 mask_right = right_indexer == -1
                 if mask_left.all():
                     key_col = rvals
-                elif mask_right.all():
+                elif right_indexer is not None and mask_right.all():
                     key_col = lvals
                 else:
                     key_col = Index(lvals).where(~mask_left, rvals)

pandas/tests/reshape/merge/test_merge.py

@@ -2349,3 +2349,20 @@ def test_merge_join_cols_error_reporting_on_and_index(func, kwargs):
     )
     with pytest.raises(MergeError, match=msg):
         getattr(pd, func)(left, right, on="a", **kwargs)
+
+
+def test_merge_right_left_index():
+    # GH#38616
+    left = DataFrame({"x": [1, 1], "z": ["foo", "foo"]})
+    right = DataFrame({"x": [1, 1], "z": ["foo", "foo"]})
+    result = pd.merge(left, right, how="right", left_index=True, right_on="x")
+    expected = DataFrame(
+        {
+            "x": [1, 1],
+            "x_x": [1, 1],
+            "z_x": ["foo", "foo"],
+            "x_y": [1, 1],
+            "z_y": ["foo", "foo"],
+        }
+    )
+    tm.assert_frame_equal(result, expected)